fix(ci): declare permissions at the top-level#83
Merged
ovflowd merged 1 commit intonodejs:mainfrom Dec 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the security configuration of the OpenSSF Scorecard workflow by moving permissions from the job level to the top level and replacing the broad read-all permission with specific, granular permissions required for the workflow to function.
Key Changes:
- Moved permissions from job-level to workflow-level in scorecard.yml
- Replaced
permissions: read-allwith specific permissions (security-events: write, id-token: write, contents: read, actions: read)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattIPv4
approved these changes
Dec 25, 2025
malav2110
approved these changes
Dec 25, 2025
bjohansebas
approved these changes
Dec 25, 2025
ovflowd
approved these changes
Dec 25, 2025
Member
|
I've fast-tracked this PR due to it causing a security workflow to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
Fixes nodejs/nodejs.org#8455
Closes nodejs/nodejs.org#8456